On Wed, 9 Jan 2013 13:14:54 +1000, Dave Airlie <[email protected]> wrote: > From: Dave Airlie <[email protected]> > > The previous fix for the previous fix, didn't fully work, > > If we don't set compat_output we end up doing derferences > of arrays with -1, leading to valgrind warnings. > > Signed-off-by: Dave Airlie <[email protected]>
Ok, that makes sense. output can only be NULL at this point iff there are no outputs and the existing compat_output is either unset or invalid. Then the value of config->compat_output always matches the xf86OutputPtr returned. And indeed explains the -1 that caused me pain recently, thanks. Reviewed-by: Chris Wilson <[email protected]> -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
