On Wed, Jan 23, 2013 at 08:04:21PM +0100, [email protected] wrote:
> > are you sure about removing that last return statement? it breaks
> > compilation, so maybe you missed a hunk here?
> 
> It is ok, but I believe I should replace the
> 
>    else if (filter->keycode == keycode)
> 
> further above by just an 'else', so that the compiler notices this as
> well.  Should I send a revised patch?

yes pleas. and tbh, I was hoping for something stronger than "I believe" :)

do you have a good test-case for this one?

Cheers,
   Peter

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to