Thanks, it's been almost a month and I thought my e-mail was forgotten.

Just to note, Arch xorg-server packages have been built with this patch applied since Feb 16 and no further problems were reported.

I hope you integrate the patch soon.

On 2013-03-15 10:39, Tomasz Lis wrote:
I agree with the change.
The handle_error jump does require framebuffer.base to be initialized.

Doing the initialization at top of __glXDRIscreenProbe body is also a good idea - even if it could be initialized lower, doing it at top gives better chance of not repeating the mistake on further modifications.

2013/2/23 Piotr Dziwinski <[email protected] <mailto:[email protected]>>

    Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=59825

    Signed-off-by: Piotr Dziwinski <[email protected]
    <mailto:[email protected]>>
    ---
     glx/glxdri.c | 2 ++
     1 file changed, 2 insertions(+)

    diff --git a/glx/glxdri.c b/glx/glxdri.c
    index da46468..a997e2f 100644
    --- a/glx/glxdri.c
    +++ b/glx/glxdri.c
    @@ -971,6 +971,8 @@ __glXDRIscreenProbe(ScreenPtr pScreen)
         size_t buffer_size;
         ScrnInfoPtr pScrn = xf86ScreenToScrn(pScreen);

    +    framebuffer.base = NULL;
    +
         if (!xf86LoaderCheckSymbol("DRIQueryDirectRenderingCapable") ||
             !DRIQueryDirectRenderingCapable(pScreen, &isCapable) ||
    !isCapable) {
             LogMessage(X_INFO,
    --
    1.8.1.3

    _______________________________________________
    [email protected] <mailto:[email protected]>: X.Org
    development
    Archives: http://lists.x.org/archives/xorg-devel
    Info: http://lists.x.org/mailman/listinfo/xorg-devel



_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to