On Mon, Mar 18, 2013 at 04:42:34PM -0700, Keith Packard wrote: > Peter Hutterer <[email protected]> writes: > > > Signed-off-by: Peter Hutterer <[email protected]> > > Ok, this took more review than I would have though. Changing the return > value assumes that all callers will be happy with the new value, in this > case, I'm betting that no-one actually uses the value at this > point. Here's an inverse call graph: > > DeliverTouchEmulatedEvent > DeliverEmulatedMotionEvent Ignores value > DeliverTouchBeginEvent > DeliverTouchEvent > DeliverTouchEvents Ignores value > DeliverTouchEndEvent > DeliverTouchEvent > DeliverTouchEvents Ignores value > > In no case do these functions actually look at the value, they simply > pass it up the call chain. Therefore, this patch will have 'no effect'. > > Reviewed-by: Keith Packard <[email protected]>
Added a note to the commit message and your inverse call graph, thanks. Cheers, Peter _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
