-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2013-06-03 17:49, Jamey Sharp wrote:
> Seems like a smart idea and solid patch. I have a couple
> suggestions you can do with as you please:
>
> On Mon, Jun 03, 2013 at 04:33:35PM -0400, Peter Harris wrote:
>> If an installed xtest is run, the user does not normally have
>> write access to the test directory. Writing intermediate files
>> and results directly to the results directory avoids a number of
>> spurious FAILs and UNRESOLVEDs.
> ...
>> +const char * +outfile(const char *fn) +{ + char *out = (char
>> *)fn;
>
> This assignment to out is dead; I'd delete the initializer.
If dirname() fails, "goto done" will return the value assigned in this
line. It appears it is not possible for dirname() to fail, so I'll
remove this and the failure check too for v2.
>> + regid(NULL, (union regtypes *)&out, REG_MALLOC);
>
> I don't know the XTS codebase (and don't want to, but...): Does
> regid register a resource to be freed at the end of the current
> test?
Yes.
> Either way: Reviewed-by: Jamey Sharp <[email protected]>
Thanks.
Peter Harris
- --
Open Text Connectivity Solutions Group
Peter Harris http://connectivity.opentext.com/
Research and Development Phone: +1 905 762 6001
[email protected] Toll Free: 1 877 359 4866
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlGtF7oACgkQsbmxTd/lXecrpACeNbliK5kvx7u5q5BrzbI4xg8z
4p8Anigcav6tKAhVQi/SCAgttIoNPMOU
=o3jE
-----END PGP SIGNATURE-----
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
