On Sun, Jun 23, 2013 at 11:00:02 -0700, Alan Coopersmith wrote:

> padl3 was declared as CARD32, which for proper alignment, got two
> additional words of padding silently inserted before it.  Declaring

s/words/bytes/ ?

> it as CARD16 aligns it properly after the CARD16 num_encodings.
> 
> Fixes clang warning:
> Xvproto.h:462:10: warning: padding struct 'struct _QueryEncodingsReply' with 
> 2 bytes to align 'padl3' [-Wpadded]
>   CARD32 padl3 B32;
>          ^
> This makes sizeof(xvQueryEncodingsReply) match the sz_xvQueryEncodingsReply
> which is used in libXv & the X server for the size sent over the wire.
> 
> Reported-by: Daniel Martin <[email protected]>
> Signed-off-by: Alan Coopersmith <[email protected]>
> ---
>  Xvproto.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Reviewed-by: Julien Cristau <[email protected]>

Cheers,
Julien
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to