On Tue, Jul 09, 2013 at 04:24:42PM +0200, Łukasz Stelmach wrote: > Hi All. > > I've fixed the problems reported for the previous release and those I had > found myself. > > Let me describe each patch. > > 1. Add const qualifier to unix_nolisten. > > Without const I got a warning and tcp_nolisten is marked as const too.
Reviewed-by: Peter Hutterer <[email protected]> > > 2. Define TRANS_RECEIVED flag for transports > > The patch defines a new flag to mark transports related to sockets > received from systemd. The next patch uses it to omit the marked > transports in the "for" loop and do not create sockets for them. I > chose not to use TRANS_NOLISTEN because it affects other parts of > code too. Acked-by: Peter Hutterer <[email protected]> looks correct, but I haven't dabbled in that code before. (fwiw, typo "alredy", should be fixed before pushing) > 3. Enable systemd socket activation > > The main patch. It enables libxtrans to "catch" and reopen > file descriptors received from systemd via its socket passing > interface. With this patch applied and systemd properly configured, > it is possible to: > > + start an X server on demand, when the first connection from a client > comes in, > > + start X clients before an X server is fully functional. Acked-by: Peter Hutterer <[email protected]> > 4. configure.ac: enable systemd socket activation in libxtrans > > Modify configure.ac to: > > + add -DHAVE_SYSTEMD to CFLAGS to enable the socket activation code > from libxtrans, and > > + libsystemd-daemon in LDFLAGS. see my comments > > 5. Do not define ErrorF in xstrans.c, libxtrans handles it. > > Yet another cleanup due to warning message. Reviewed-by: Peter Hutterer <[email protected]> Cheers, Peter > > Łukasz Stelmach for libxtrans (3): > Add const qualifier to unix_nolisten > Define TRANS_RECEIVED flag for transports > Enable systemd socket activation > > Xtrans.c | 97 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > Xtrans.h | 4 +++ > Xtransint.h | 1 + > Xtranssock.c | 2 +- > 4 files changed, 102 insertions(+), 2 deletions(-) > > Łukasz Stelmach for xserver (2): > configure.ac: enable systemd socket activation in libxtrans > Do not define ErrorF in xstrans.c, libxtrans handles it. > > configure.ac | 32 ++++++++++++++++++++++++++++++++ > os/xstrans.c | 5 ----- > 2 files changed, 32 insertions(+), 5 deletions(-) > > -- > 1.7.9.5 > _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
