On Sat, Jul 27, 2013 at 23:38:43 +0200, Mark Kettenis wrote: > > From: Julien Cristau <[email protected]> > > Date: Sat, 27 Jul 2013 21:08:29 +0200 > > The "os.h" header should probably be included even in if > HAS_SAVED_IDS_AND_SETEUID is defined, as in that case ErrorF gets > called, which also lives in "os.h". Not sure why that doesn't cause > warnings on other systems. Probably they pull in "os.h" as a > side-effect. So perhaps you should just include it unconditionally > with the other Xserver headers. > ack
> Note that the fact that you're hitting this code on GNU/kFreeBSD is > almost certainly wrong. No modern UNIX-line OS should hit that code. > That path is used unless defined(SVR4) || defined(__linux__) || defined(CSRG_BASED). Maybe that should be changed to an autoconf test instead... Cheers, Julien _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
