On Tue, Oct 08, 2013 at 10:06:41AM -0400, Gaetan Nadon wrote:
> This is a wrapper library for evdev devices. It is a dependency
> for xf86-input-evdev and more modules later.
> 
> Only recent kernel versions are supported and there is currently no
> check at configuration time, so you just get compile errors.

tbh, you can't easily check for that because the kernel version is rather
meaningless.
for the #defines you can override them (see the patches), for ioctls it's a
bit more complicated. and we backport a lot of features to RHEL kernels, so
a simple version check is actually quite unreliable to begin with.

otherwise, Reviewed-by: Peter Hutterer <[email protected]>, thanks!

> Building from tar file will not work at the moment as the .xv
> format is not yet supported by build.sh.

having (only quickly) looked at this code, I don't think we even need to know 
about
the type of tarball. "tar xf" is enough for at least GNU tar, no need to
append the compression format. would be interesting to know about the other
platforms here. but if it's not required, we can loop through *.tar.* and
just go from there.

Cheers,
   Peter

> Also note that the -o option is broken with single name modules
> like pixman or libevdev. Use --modfile as a workaround to build
> a single module.
> 
> Signed-off-by: Gaetan Nadon <[email protected]>
> ---
>  build.sh |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/build.sh b/build.sh
> index 5cd0814..0bcb86b 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -302,6 +302,9 @@ clone() {
>      "xkeyboard-config")
>          BASEDIR=""
>          ;;
> +    "libevdev")
> +        BASEDIR=""
> +        ;;
>      *)
>          BASEDIR="xorg/"
>          ;;
> @@ -916,6 +919,12 @@ build_driver() {
>          Darwin) return 0 ;;
>      esac
>  
> +# Build the Wrapper library for evdev devices
> +    case $HOST_OS in
> +     Linux)
> +         build libevdev ""
> +         ;;
> +    esac
>      build_driver_input
>      build_driver_video
>  }
> -- 
> 1.7.9.5
> 
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to