On 11/21/13 10:19 PM, Keith Packard wrote:
+    newfd = fcntl(fd, F_DUPFD, MAXCLIENTS);

Should probably do something like:

#ifdef F_DUPFD_CLOEXEC
        newfd = fcntl(fd, F_DUPFD_CLOEXEC, MAXCLIENTS);
#else
        newfd = fcntl(fd, F_DUPFD, MAXCLIENTS);
#endif
        if (newfd < 0)
                return fd;
#ifndef F_DUPFD_CLOEXEC
        fcntl(newfd, F_SETFD, FD_CLOEXEC);
#endif

so that we don't pass all those fds to xkbcomp when we fork it.

--
        -Alan Coopersmith-              [email protected]
         Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to