Alberto Milone <[email protected]> writes: > I thought about it but I also thought that RRSetChanged() would get > master anyway. > > The potential benefit of passing the gpu screen is that if we ever > wanted to do something on the gpu screen in RRSetChanged() (other than > setting screen->changed to TRUE) before getting master, we could do that.
Ah, ok. Well, then don't set 'master' in the else -- you aren't using it. > If you think that RRSetChanged() will always just set master->changed > (as the name of the function suggests), then I guess we should simply > pass master instead. No, your plan is sound, just that you've got an unused variable in the 'else' clause, which I worried was an indication of a bug. -- [email protected]
pgpSjDvfAKfvN.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
