On 12/11/13 10:47 PM, Keith Packard wrote:
Alan Coopersmith <[email protected]> writes:
On 12/11/13 12:24 PM, Keith Packard wrote:
No need to have a duplicate definition here.
include/dixfontstubs.h | 2 --
But the comment at the top of the header says nothing includes it,
it's just there for sdksyms to use, so why does this reduce warnings?
git grep doesn't find any uses outside of hw/xfree86/sdksyms.sh.
sdksyms also includes font.h from fontsproto, which also declares
GetClientResolutions, so when you build the resulting sdksyms.c, you get
a duplicate definition.
Ah right, digging back into the history, found the previous fixes here
said the duplication was now limited to GetClientResolutions to avoid
having to change fontsproto to match.
Unfortunately, I don't remember off hand what, if anything, needs the
GetClientResolutions symbol exported from the server, so unless someone
wants to verify it's not needed, I'd like to see sdksyms continue to
export the symbol - as long as that happens, I'm happy.
--
-Alan Coopersmith- [email protected]
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
