Eric Anholt <[email protected]> writes: > I don't think these comments wanted to change.
Sorry for missing those. >> - free((pointer) pScreenPriv); >> + free((void *) pScreenPriv); > > Casting to void * to pass to a function taking void *? I guess cleanups > of that can be left to a coccinelle patch later. Might as well fix it now. > space got lost. But these protos are hideous anyway. ... > same ... > lost space I made all of the protos pretty; I'll send that along as a separate patch. > unintentional comment change. Fixed, along with a free ((void *)x) usage > bad comment change. Fixed > bad comment change. Fixed. >> diff --git a/Xi/listdev.c b/Xi/listdev.c > bad whitespace change. Fixed. >> diff --git a/Xi/xiwarppointer.c b/Xi/xiwarppointer.c > bad comment change. Fixed. >> diff --git a/dix/devices.c b/dix/devices.c > bad whitespace > bad whitespace > bad whitespace. > bad comment > bad whitespace Fixed >> diff --git a/dix/dixfonts.c b/dix/dixfonts.c > bad comment Fixed > bad comment Fixed. >> diff --git a/dix/dixutils.c b/dix/dixutils.c > space loss Will be in prototype cleanup patch. >> diff --git a/dix/events.c b/dix/events.c > bad whitespace Fixed. >> diff --git a/dix/privates.c b/dix/privates.c > Ahahah, a pointer <-> void change going the other direction. I > approve, though. Fixed whitespace. >> diff --git a/glx/indirect_util.c b/glx/indirect_util.c > bad whitespace Fixed. >> diff --git a/hw/dmx/dmxcursor.c b/hw/dmx/dmxcursor.c > bad comment Fixed >> diff --git a/hw/dmx/dmxinit.c b/hw/dmx/dmxinit.c > bad comment Fixed. >> diff --git a/hw/dmx/input/dmxinputinit.c b/hw/dmx/input/dmxinputinit.c > bad code change! > same Fixed. >> diff --git a/hw/dmx/input/dmxinputinit.h b/hw/dmx/input/dmxinputinit.h > bad comment Fixed. >> diff --git a/hw/kdrive/src/kcmap.c b/hw/kdrive/src/kcmap.c > bad comment Fixed. >> diff --git a/hw/xfree86/common/xf86DGA.c > bad whitespace Fixed >> diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c > bad comment > bad comment Fixed. >> diff --git a/hw/xfree86/common/xf86Init.c b/hw/xfree86/common/xf86Init.c > bad code change Fixed. >> diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c > bad comment Fixed >> diff --git a/hw/xfree86/modes/xf86Modes.c b/hw/xfree86/modes/xf86Modes.c > bad comment > bad comment Fixed >> diff --git a/hw/xfree86/os-support/bus/xf86Pci.h >> b/hw/xfree86/os-support/bus/xf86Pci.h > bad comment Fixed >> diff --git a/hw/xfree86/os-support/solaris/sun_init.c >> b/hw/xfree86/os-support/solaris/sun_init.c > bad comment Fixed. >> diff --git a/hw/xfree86/x86emu/x86emu/regs.h >> b/hw/xfree86/x86emu/x86emu/regs.h > bad comment Fixed >> diff --git a/hw/xwin/winallpriv.c b/hw/xwin/winallpriv.c > bad commment Fixed. >> diff --git a/hw/xwin/winconfig.c b/hw/xwin/winconfig.c > bad code changes Fixed. >> diff --git a/hw/xwin/windialogs.c b/hw/xwin/windialogs.c > bad comment Fixed. > missing space between 'void *' and the start of the comment all through > the changes to include/. I won't point them out individually. How about we plan on rewriting the prototypes to not be ugly? >> diff --git a/include/list.h b/include/list.h > bad comment Fixed >> diff --git a/mi/midispcur.c b/mi/midispcur.c > bad comment Fixed >> diff --git a/mi/migc.h b/mi/migc.h Prototypes to be fixed in follow on patch >> diff --git a/mi/miglblt.c b/mi/miglblt.c > unrelated whitespace change Fixed. >> diff --git a/mi/mipointer.h b/mi/mipointer.h > bad comment Fixed >> diff --git a/os/xdmcp.c b/os/xdmcp.c > spaces in this file New prototypes to follow >> diff --git a/randr/rrscreen.c b/randr/rrscreen.c > bad commment Fixed >> diff --git a/record/record.c b/record/record.c > space Prototypes fixed in follow-on patch >> diff --git a/test/xi2/protocol-common.c b/test/xi2/protocol-common.c > bad whitespace Fixed -- [email protected]
pgpPqEZrhhhQn.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
