Hi, On 18 January 2014 16:27, Hans de Goede <[email protected]> wrote: > On 01/17/2014 02:08 PM, Daniel Stone wrote: >> On 15 January 2014 14:32, Hans de Goede <[email protected]> wrote: >>> With systemd-logind the dbus-core will be used for more then just config. >>> >>> This patch also makes the building of the dbus-core and udev no longer >>> mutually exclusive and removes the config_ prefix from the dbus-core >>> symbols. >> >> The rest of your patchset looks good to me, but I'd rather this not >> get moved to hw/xfree86/. Historically, hw/xfree86/ has been a bit of >> a ghetto that we've tried to move things out of, because the majority >> of code in there is really terrible. It also means you can't use HAL >> support on non-XFree86 DDXes, which I admit is entirely a theoretical >> concern atm, but still ... > > Suggestions for where it should be moved instead then ? Putting it in the os > dir means all kinda binaries which are not using dbus at all start depending > on it too... Maybe leave it in config (while keeping the other changes ?
I'd just leave it in config/ to be honest. It's a poorly-named directory, but seriously, no directory in xserver/ is named well. The intention originally was that it'd be used for runtime configuration changes, but we realised that was a terrible idea, so abandoned it. So now it's basically external-device-enumeration-and-notification-mechanism/. I don't think it's a good fit for os/ either, as that's essentially very thin wrappers around core POSIX, plus client/socket handling. Cheers, Daniel _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
