On 21/01/2014 23:16, Martin Peres wrote:
> On 18/01/2014 17:19, Samuel Pitoiset wrote:
>> V2:
>> - Add support for unmapping
>> - Add a README.cygwin
>>
>> Reviewed-by: Martin Peres <[email protected]>
> Ping

It would be helpful if the subject mentioned this is a patch to libpciaccess.
(You may find 'git config format.subjectprefix' useful)

The only comment I was going to make was that it needs to say where to get
WinIo from, which you have addressed in v2.

Reviewed-by: Jon TURNEY <[email protected]>

> I checked and it doesn't seem to affect Linux's compilation at all.
> It is useful for Nouveau, to reverse the performance counters on
> Windows (because NVIDIA doesn't think Linux users would want
> to profile their GL apps).
> 
> Could anyone push it before everyone looses interest and people
> start forgetting this port exists and rewrite support for it? It took
> quite a some time to Samuel to look through the gazillion ways of
> accessing the BARs on Windows and then implement support for
> it.

I'll push this in a couple of days, if there are no objections.

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to