David Sodman <[email protected]> writes:

> The function RRCrtcSet call checks to see if the config being set is
> already configured, but, doesn't check that the selected outputs are
> connected to the crtc before skipping.  This means that the following
> sequence will omit the final CrtcSet call to the driver:
>
>     CRTC c1 connect to output o
>     CRTC c2 connect to output o
>     CRTC c1 connect to output o
>
> This change adds the check to ensure that each of the calls are made to
> the driver.
>
> Signed-off-by: David Sodman <[email protected]>
> Reviewed-by: Stephane Marchesin <[email protected]>

This generates a warning:

 CC       rrcrtc.lo
rrcrtc.c: In function 'RRCrtcSet':
rrcrtc.c:618:17: warning: declaration of 'o' shadows a previous local [-Wshadow]
             int o;
                 ^
rrcrtc.c:526:9: warning: shadowed declaration is here [-Wshadow]
     int  o;
         ^

-- 
[email protected]

Attachment: pgpYu6fTI1tkU.pgp
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to