Egbert Eich <[email protected]> writes: > Limiting the the cursor coordinates on the bounding box of a shaped > window before applying ConfineTo leads to strange cursor placement > when the pointer is located outside the vertial and horizontal > strip of this bounding box. > Ignoring the bounding box when a shape is set leads to the correct > behavior.
This seems reasonable to me. > - pSprite->hotLimits = *RegionExtents(&pWin->borderSize); > + if (!wBoundingShape(pWin)) > + pSprite->hotLimits = *RegionExtents(&pWin->borderSize); This seems like a bad idea to me -- hotLimits is used in calls to pScreen->CursorLimits, and you're now not setting it when the new window has a bounding shape. I don't think this will cause a problem, but I'm not sure what this change accomplishes as physLimits (which is computed by CursorLimits from hotLimits) is never used when the window has a bounding shape. I suggest just leaving hotLimits set as it was, in case some driver actually cares about it. Everything else is Reviewed-by: Keith Packard <[email protected]> -- [email protected]
pgpV0Wnt4D6QZ.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
