On 14-02-19 12:59 PM, Mark Kettenis wrote: >> Date: Wed, 19 Feb 2014 12:45:32 -0500 >> From: Gaetan Nadon <[email protected]> >> >> This is great feedback. So links are not the ideal solution, in fact, no >> solution at all for many. >> >> To my knowledge, this leaves us with the ideal solution I call "code >> re-factoring" to replace the cherry-picking of reusable source files >> which is exemplified by Jon Turney 's patch earlier in this thread. >> >> I've CC Emil Velikov for Mesa who has a bug report for the same issue. >> >> I am withdrawing this patch series and turning the problem over to the X >> server developers. There are 18 makefiles that are broken under automake >> 2.0 (warnings under 1.14). > Note that not all warnings are actually problems. For example the > directories under hw/xfree86/os-support are largely subdir-objects > safe. Probably enough to make sure hw/xfree86/os-support/shared gets > created in the build directory before entering the OS-specific > directory. The same is probably true for os/strlcpy.c and > os/strlcat.c. Although those files are defenitely candidates for a > libtool convenience library. > Yes, various areas of the server code require different solutions. In order to also clear the warnings, the $(srcdir)/../ will half to go. I have seen patches submitted providing workarounds, but if automake does not allow something by design, the implementation can always change and what used to work now doesn't anymore.
Thanks. _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
