On 14-03-19 12:51 PM, Guillem Jover wrote:
> One reason to use something (in spirit) like this is to avoid
> unnecessary line changes whenever a new entry is appended to the list,
> which might also generate less conflicts. I tend to use $(nil) as the
> last item in those cases. The other option is to switch the assignment
> to “=+”, but that seems more verbose.
Now that you mention it, I recall seeing this somewhere.
I went back and there was only one offending construct:
if GLAMOR
GLAMOR_SRCS = \
ephyr_glamor_glx.c \
ephyr_glamor_glx.h \
()
endif
Producing:
make[3]: Entering directory
`/home/nadon/xorg/src/xserver/hw/kdrive/ephyr'
make[3]: *** No rule to make target `()', needed by `distdir'. Stop.
make[3]: Leaving directory
`/home/nadon/xorg/src/xserver/hw/kdrive/ephyr'
make[2]: *** [distdir] Error 1
It's a typo where "()" was written instead of "$()". I wrongly assumed
they were all bad, typos or not!
I'll write another patch.
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
