Daniel Kurtz <[email protected]> writes: > Hi Keith, > Thank you very much for your detailed review. Your patch looks great. > Just one small detail. > Are src/dst_byte_stride still "FbStride" if they count bytes not > FbBits? Perhaps they are size_t?
FbStride will be fine (it's an 'int'). X pixmaps cannot be larger than 65536 x 65536 pixels, and so the maximum stride is well under 32 bits, measured in FbBits, bytes or even bits. > Either way, for your attached patch: > > Reviewed-by: Daniel Kurtz <[email protected]> Thanks for your review; glad we got that sorted out, and really glad you identified the bug so clearly. -- [email protected]
pgpr1uNQ4awhQ.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
