Eric Anholt <[email protected]> writes:

>>  
>>              vblank->pixmap = NULL;
>>              vblank->idle_fence = NULL;
>> +            vblank->flip = FALSE;
>> +            if (vblank->flip_ready)
>> +                present_re_execute(vblank);
>>          }
>>      }
>>  
>
> So, when we're replacing a previous flip for a given MSC with a new
> presented pixmap for the same MSC, we disable pageflip for it.  I don't
> see anything else that would reset the flip bit (flip only gets set in
> present_pixmap below).  Shouldn't we be doing a vblank->flip =
> check_flip(...), instead?

This is smashing the state of the vblank which is no longer going to be
executed. The new pending vblank will be flipped as appropriate.

-- 
[email protected]

Attachment: pgpjuQciBDaqm.pgp
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to