Jon TURNEY wrote:
On 08/30/13 07:55 AM, Adam Jackson wrote:
I introduced this bug, and I have no idea what I was thinking. The
xinerama_sleep label I introduced is actually the closure cleanup path.
What you actually want to do is re-queue the work, which is spelled
ClientSignal.
To reproduce this bug, add a font server to your font path, run xfontsel,
and watch your X server crash.
Unfortunately, when I tried my testcase in that bug against an XWin X server
with that patch applied, instead of crashing, the X server process just spins.
I hit the original bug on Solaris, so also tried this patch and similarly got
looping. Stopping in the debugger it had gotten wedged in the loop in
ProcessWorkQueue because doListFontsWithInfo keeps sticking itself back in
the queue. Getting rid of all the ClientSignal() calls added in this patch
stopped that. (Still can't run xterm with a font path of just built-ins +
xfs, but that seems more deeply broken.)
--
-Alan Coopersmith- [email protected]
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel