From: Ray Strode <rstr...@redhat.com> wakeup handlers are called even when select() returns EINTR, and when they're called the passed fd set is undefined.
This commit fixes the dbus wakeup handler to avoid dispatching into dbus spuriously. Reviewed-by: Adam Jackson <a...@redhat.com> Signed-off-by: Ray Strode <rstr...@redhat.com> --- config/dbus-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/dbus-core.c b/config/dbus-core.c index b0fd92d..8351ea4 100644 --- a/config/dbus-core.c +++ b/config/dbus-core.c @@ -48,11 +48,11 @@ static struct dbus_core_info bus_info; static CARD32 reconnect_timer(OsTimerPtr timer, CARD32 time, void *arg); static void -wakeup_handler(void *data, int err, void *read_mask) +wakeup_handler(void *data, int num_fds, void *read_mask) { struct dbus_core_info *info = data; - if (info->connection && FD_ISSET(info->fd, (fd_set *) read_mask)) { + if (info->connection && num_fds > 0 && FD_ISSET(info->fd, (fd_set *) read_mask)) { do { dbus_connection_read_write_dispatch(info->connection, 0); } while (info->connection && -- 1.8.5.3 _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel