Keith Packard <[email protected]> writes: > glamor_transfer had some hard-coded depth to format/type conversions > which may not match the format used with render. This switches to > using the same formats as the render portion of glamor.
glamor_get_tex_format_type_from_pixmap() looks hopelessly broken. It's trying to choose the texture's actual channel layout using the format/type arguments to TexImage. But GL doesn't say anything about format/type implying anything about the resulting texture channel sizes or layout -- until ARB_texture_view, it just strongly implies that format/type doesn't matter, and with ARB_texture_view and ARB_shader_image_load_store it's guaranteed that it doesn't matter. So what you end up doing here is saying "oh, somebody's attached a 2101010 picture to my pixmap! Now in PutImage I'll upload my 32 bits of data as 2 bits expanded into the 8-bit alpha and 10 bits truncated into the 8 bits or r, g, and b." For bonus brokenness, delete the picture (unsetting pixmap_priv->base.picture), and do a GetImage (now using format_for_depth, 8888 like before), and your data is trashed because you read your actually-8888 data as 8888 without doing any bitshifting to partially recover from the 2101010->8888 screwup. I think instead we want to just rip out the wacky-format support from glamor_render.c and the pixmap_priv->picture field, and fall back until we get texture_view code.
pgpsOWUS9bXce.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
