On 26/04/14 00:52, Keith Packard wrote:
Frank Binns <[email protected]> writes:
In the case that synchronised page flips are being performed, it's
possible to hit this assert when killing an application. This is a
result of the pending flip being flagged as aborted, as part of
window destruction, but the pending flip not being cleared until the
corresponding flip event has been received.
It doesn't appear that there is any problem with setting an aborted
pending flip's window to NULL. For this reason remove the assert.
I assume this is only the case when you leave the pending flip around
after the window is destroyed with your previous patch?
Without the previous patch this assert would still be hit because
although present_abort_vblank() was being called on the pending
flip, the pending flip wasn't being cleared from the screen private
data. In fact, it's the previous patch which makes it harmless for
there to be a pending flip when present_clear_window_flip() is
called.
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
