Brendan King <[email protected]> writes: > Without the patch in place, screen->DeviceCursorCleanup was never > being called, as dev->spriteInfo->sprite was NULL for every > device. DisableDevice is called before CloseDevice, and DisableDevice > will call FreeSprite if the device is enabled, which will set > dev->spriteInfo->sprite to NULL.
Thanks for your explanation; this all makes sense now. DisableDevice was changed to free the sprite back on 2012-06-06 in commit df1704365e700d3cf1d36a241bdfc479159a8df7 Looks like we've been leaking the cursor stuff for a while now. And, it looks like the FreeSprite call is entirely unnecessary in CloseDevice as DisableDevice is always called first from RemoveDevice. Reviewed-by: Keith Packard <[email protected]> -- [email protected]
pgp8EAlewk1hL.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
