Hi, On 06/16/2014 06:54 PM, Rob Clark wrote: > On Mon, Jun 16, 2014 at 11:12 AM, Hans de Goede <[email protected]> wrote: >> Hi, >> >> On 06/16/2014 05:05 PM, Rob Clark wrote: >>> Give the DDX a way to know whether non-pci platform devices are >>> completley broken or not. For xserver prior to the fix, the >>> DDX should not claim a platform device in platformProbe(), as >>> the server will fallback to old ->Probe(), which will fail if >>> the device is already claimed. Meaning that a user could not >>> make things work even with a .conf file to explicitly specify >>> the driver to use. >>> --- >>> hw/xfree86/common/xf86platformBus.c | 4 ++++ >>> hw/xfree86/common/xf86str.h | 3 ++- >>> 2 files changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/hw/xfree86/common/xf86platformBus.c >>> b/hw/xfree86/common/xf86platformBus.c >>> index bb4c71d..3af107e 100644 >>> --- a/hw/xfree86/common/xf86platformBus.c >>> +++ b/hw/xfree86/common/xf86platformBus.c >>> @@ -410,6 +410,10 @@ xf86platformProbeDev(DriverPtr drvp) >>> const unsigned numDevs = xf86MatchDevice(drvp->driverName, &devList); >>> int i, j; >>> >>> + /* let driver know to expect non-pci platform devices to work: */ >>> + if (drvp->driverFunc) >>> + drvp->driverFunc(NULL, SERVER_SUPPORTS_NON_PCI_PLATFORM_DEVS, >>> NULL); >>> + >> >> IMHO this call would fit better in hw/xfree86/common/xf86Init.c in the loop >> around line 550 where xf86DriverList[i]->driverFunc(NULL, >> GET_REQUIRED_HW_INTERFACES >> gets called. > > ok, I can move it
Good, with that fixed you can add my Reviewed-by. Regards, Hans _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
