David Ung <[email protected]> writes:

> ping?
>
> ________________________________________
> From: David Ung [[email protected]]
> Sent: Thursday, July 17, 2014 5:19 PM
> To: [email protected]
> Cc: David Ung
> Subject: [PATCH] randr: Fix logic in RRPointerToNearestCrtc
>
> RRPointerToNearestCrtc is suppose to snap to the nearest Crtc,
> but the code is buggy.  Correct the calculation of delta x/y
> values and choose the closest Crtc.

This comment isn't terribly descriptive of the problems it's
solving. There are two -- one where the dx/dy values end up off-by-one
and another where it's simply forgetting to actually set the 'best' value.

> +        dist = abs(dx) + abs(dy);

You don't need abs here; dx and dy are always positive.

-- 
[email protected]

Attachment: pgpYUND4HBv0f.pgp
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to