Adam Jackson <[email protected]> writes: > On Wed, 2014-08-20 at 11:48 -0500, Keith Packard wrote: >> Adam Jackson <[email protected]> writes: >> >> > The gotos deleted by this patch are the only way to get to the bail: >> > label here. In neither case do we need to free the cursor bits from the >> > caller; AllocARGBCursor will already do that on the failure path, >> > likewise AddResource will call the resource delete function on error. >> >> I don't see AllocARGBCursor freeing anything in the failure paths, so I >> think we need to free source/mask. We also need to free argbits > > I'm not making shit up, I promise. AllocARGBCursor glues the source and > mask parameters into the cursor bits near the top:
Yeah, I saw that part after I'd noticed that the first error return (on malloc failure) didn't free anything. -- [email protected]
pgpUYNyR8UPin.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
