Keith Packard <kei...@keithp.com> writes: > Declare a constant string 'const', clean up some indentation whitespace
OK, instead of ad-hoc writing that command every time, I put a script in ~/bin: anholt@eliezer:xf86-video-intel/src/uxa% git whitespace-vote tabs: 17202 spaces: 518 anholt@eliezer:xf86-video-intel/src/uxa% git whitespace-vote intel_display.c tabs: 1278 spaces: 184 So there's a bunch of disagreement between this new code and existing practice about whitespace, and still misc unrelated whitespace changes sprinkled into the remaining patches. That makes me grumpy when reviewing, but I don't actually care to block things due to that. This driver is enough of a disaster already that whitespace inconsistency isn't its main problem. Patches 1-3, 5-6, 8, 12-15 are: Reviewed-by: Eric Anholt <e...@anholt.net> 16-18: I'm still looking at them.
pgpq5xGBPwgTJ.pgp
Description: PGP signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
