Alan Coopersmith <[email protected]> writes: > Coverity scan detected that asserts were setting values, not checking them: > > CID 53252: Side effect in assertion (ASSERT_SIDE_EFFECT) > assignment_where_comparison_intended: Assignment item->b = i * 2 > has a side effect. This code will work differently in a non-debug build. > Did you intend to use a comparison ("==") instead? > > CID 53259: Side effect in assertion (ASSERT_SIDE_EFFECT) > assignment_where_comparison_intended: Assignment item->a = i > has a side effect. This code will work differently in a non-debug build. > Did you intend to use a comparison ("==") instead? > > CID 53260: Side effect in assertion (ASSERT_SIDE_EFFECT) > assignment_where_comparison_intended: Assignment item->a = i > has a side effect. This code will work differently in a non-debug build. > Did you intend to use a comparison ("==") instead? > > CID 53261: Side effect in assertion (ASSERT_SIDE_EFFECT) > assignment_where_comparison_intended: Assignment item->b = i * 2 > has a side effect. This code will work differently in a non-debug build. > Did you intend to use a comparison ("==") instead? > > Fixing those to be == caused test_nt_list_insert to start failing as > part assumed append order, part assumed insert order, so it had to be > fixed to use consistent ordering. > > Signed-off-by: Alan Coopersmith <[email protected]>
Merged (with review): d0da0e9..8f8dcfe master -> master -- [email protected]
pgpeY_ttw6ayd.pgp
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
