On 04/09/2014 18:59, Eric Anholt wrote:
Almost every situation of someone running indirect GLX is a mistake
that results in X Server crashes. Indirect GLX is the cause of
regular security vulnerabilities, and rarely provides any capability
to the user. Just disable it unless someone wants to enable it for
their special use case (using +iglx on the command line).
---
I kept saying I as going to send out this patch, and since I just
crashed my server a few times from trying to run Xephyr -glamor with a
broken driver, it's probably time.
os/utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/os/utils.c b/os/utils.c
index f319743..c83f77d 100644
--- a/os/utils.c
+++ b/os/utils.c
@@ -194,7 +194,7 @@ Bool noGEExtension = FALSE;
Bool CoreDump;
-Bool enableIndirectGLX = TRUE;
+Bool enableIndirectGLX = FALSE;
#ifdef PANORAMIX
Bool PanoramiXExtensionDisabledHack = FALSE;
I think the text in os/utils.c which says +iglx is the default needs to
be removed or updated as well.
Patch attached.
From 29806e9ad431377b0ada4b453668ca3c16a4f817 Mon Sep 17 00:00:00 2001
From: Jon TURNEY <[email protected]>
Date: Tue, 16 Sep 2014 15:15:11 +0100
Subject: [PATCH] Update help text since -iglx is now the default
Update help text to align with d0da0e9c3bb8fe0cd4879ecb24d21715bfaa209b
Signed-off-by: Jon TURNEY <[email protected]>
---
os/utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/os/utils.c b/os/utils.c
index c83f77d..2d02f92 100644
--- a/os/utils.c
+++ b/os/utils.c
@@ -541,8 +541,8 @@ UseMsg(void)
ErrorF("-fn string default font name\n");
ErrorF("-fp string default font path\n");
ErrorF("-help prints message with these options\n");
- ErrorF("+iglx Allow creating indirect GLX contexts
(default)\n");
- ErrorF("-iglx Prohibit creating indirect GLX contexts\n");
+ ErrorF("+iglx Allow creating indirect GLX contexts\n");
+ ErrorF("-iglx Prohibit creating indirect GLX contexts
(default)\n");
ErrorF("-I ignore all remaining arguments\n");
#ifdef RLIMIT_DATA
ErrorF("-ld int limit data space to N Kb\n");
--
2.1.0
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
