Adam Jackson <[email protected]> writes:

> +        if (pGC->graphicsExposures) {
> +            RegionRec rgn;
> +            int dx, dy;
> +
> +            /* create region for source box */
> +            BoxRec sourceBox = { srcx, srcy, srcx + width, srcy + height };

Would be nice to have named member initializers here...

> +            RegionInit(&rgn, &sourceBox, 1);
> +
> +            dx = drawables[0]->x;
> +            dy = drawables[0]->y;
> +            if (srcIsRoot) {
> +                dx += screenInfo.screens[0]->x;
> +                dy += screenInfo.screens[0]->y;
> +            }

Are you sure you don't need this for every window? I thought every
window on each panoramiX screen was offset within the screen.

> +
> +            /* translate from source-relative to screen */
> +            RegionTranslate(&rgn, dx, dy);

You could just create sourceBox with the right coordinates here. Just sayin'

-- 
[email protected]

Attachment: pgpjJ8ON8E9LC.pgp
Description: PGP signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to