Eric Anholt <[email protected]> writes: >> --- a/glamor/glamor_xv.c >> +++ b/glamor/glamor_xv.c >> @@ -435,7 +435,7 @@ glamor_xv_put_image(glamor_port_private *port_priv, >> } >> >> top = (src_y) & ~1; >> - nlines = (src_y + height) - top; >> + nlines = (src_y + src_h) - top; >> >> switch (id) { >> case FOURCC_YV12: > > If the point is to upload only from the src_[xywh] recctangle, shouldn't > the glamor_upload_sub_pixmap_to_texture() calls be using src_w instead > of width, too?
It doesn't need to, but it could as an optimization. Skipping lines at the top and bottom is also just an optimization as the source rectangle defines a subset of the provided buffer, after all. I just fixed that optimization. -- [email protected]
signature.asc
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
