On Monday, December 29, 2014 02:30:06 PM Keith Packard wrote: > * PGP Signed by an unknown key > > > Keith, any chance of getting this in for 1.17? I know you expressed > > reservations about it, but the current code definitely corrupts the > > timer list and is affecting a bunch of people, so this patch is > > certainly better than nothing. > > Yeah, it's an ugly little bit of code, and still seems prone to racing > when the timer list is modified from a timer callback.
Sorry, how modification of timer list from callback causes race condition? OsTimerRec is static to waitFor.c and before any modification in timer list we are blocking os signals. Also before callback we remove timer from timer list first. > This reduces the > window, but doesn't close it. > > But, as you say, it seems better than the current code. ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
