Aaron Plattner <[email protected]> writes: > From: Nikhil Mahale <[email protected]> > > Fixing following kind of race-conditions - > > WaitForSomething() > | > ----> // timers -> timer-1 -> timer-2 -> null > while (timers && (int) (timers->expires - now) <= 0) > // prototype - DoTimer(OsTimerPtr timer, CARD32 now, > OsTimerPtr *prev) > DoTimer(timers, now, &timers) > | > | > ----> OsBlockSignals(); .... OS Signal comes just before > blocking it, > .... timer-1 handler gets called. > // timer-1 gets served and > scheduled again; > // timers -> timer-2 -> timer-1 > -> null > .... > *prev = timer->next; > timer->next = NULL; // timers -> null > // timers list gets corrupted here and timer-2 gets > removed from list. > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=86288 > Signed-off-by: Nikhil Mahale <[email protected]> > Reviewed-by: Julien Cristau <[email protected]> > > v2: Apply warning fixes from Keith Packard <[email protected]> > > Reviewed-by: Aaron Plattner <[email protected]> > Signed-off-by: Aaron Plattner <[email protected]>
Merged. 58f28b0..fe4c774 master -> master -- -keith
signature.asc
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
