On 12/02/15 22:14, Alan Coopersmith wrote: > On 02/10/15 06:55 AM, Emil Velikov wrote: >> With earlier commit we're including config.h before the system headers. >> As such we no longer require the extra define as it is handled/set via >> AC_USE_SYSTEM_EXTENSIONS. Note platforms which do not use autotools but >> require the define (such as Android) might need to set it explicitly. >> >> Suggested-by: Alan Coopersmith <[email protected]> >> Signed-off-by: Emil Velikov <[email protected]> > > I didn't realize anyone was building libpciaccess without using autotools. > If this helps them, leaving one extra #define in the source doesn't hurt > us, > so I don't mind skipping this little cleanup. > To build for Android one requires additional patch, adding their makefile - Android.mk. The latter already sets a handful of defines manually. With that said - fixing their build should be dead trivial, but I don't have a strong opinion either way :-)
-Emil _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
