Matt Turner <[email protected]> writes: > The texture2D() happens in each branch, so we may as well do it as early > as possible and hide some of its latency in the branching instructions. > Moving it outside the (uniform) control flow reduces the number of > instructions in the fs_source shader from 64 to 46 and in the > set_alpha_source shader from 69 to 47 on Haswell. > --- > Untested. Given a short primer on benchmarking glamor I'd be happy > to run some benchmarks.
I wouldn't worry about the benchmarking on this one -- it seems obviously better, and we're pretty skeptical of this code's existence. But since it's there and this is an improvement, I've reviewed and applied it to -next.
signature.asc
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
