Ray Strode <halfl...@gmail.com> writes: > Hi, > > On Mon, Jul 6, 2015 at 6:08 PM, Keith Packard <kei...@keithp.com> wrote: >> I liked your first version a lot better; looks a lot simpler. An >> autoconf test might make sense if there was some reason to override it? > > To be clear, I primarily gave feedback because "touched it last". I > think it makes more sense to consolidate platform checks in > configure.ac (overridable or static) because the configure script is > what does the lion's share of platform checks. Still, it's no doubt a > style question, and I'll defer on style matters to Keith/those more > intimately involved in the project than me.
Yeah, we have piles of platform checks in our header files, and when the check is as simple as the one here, it's a bit nicer to just open-code it directly rather than having a bunch of fairly complicated autoconf stuff going on. -- -keith
signature.asc
Description: PGP signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
