On 21 July 2015 at 22:18, Thomas Klausner <[email protected]> wrote: > Hi Emil! > > On Mon, Jul 20, 2015 at 05:00:43PM +0100, Emil Velikov wrote: >> On 19 July 2015 at 08:56, Thomas Klausner <[email protected]> wrote: >> > From: Matthew Green <[email protected]> >> > >> > Move X11/Xpoll.h include earlier than sys/select.h to avoid missing >> > out on setting FD_SETSIZE early enough. >> > >> Shouldn't there be a comment to prevent the next person from >> reverting/messing up with the order ? >> >> ... >> > diff --git a/os/io.c b/os/io.c >> > index 124ecd8..8ebb8e4 100644 >> > --- a/os/io.c >> > +++ b/os/io.c >> > @@ -46,6 +46,8 @@ in this Software without prior written authorization >> > from The Open Group. >> > * THIS SOFTWARE. >> > */ >> > >> > +#include "X11/Xpoll.h" >> > + >> > #include "config.h" >> > >> This looks like a no-go. I cannot think of a case where you'd want >> anything before config.h. > > So would you like the attached patch pushed too? > Yes that's perfect. Can you please add the comment in os/connection.c as well please.
With that the patch is Reviewed-by: Emil Velikov <[email protected]> >> Mildly related: how many cases in Xorg are there, where config.h is >> not the first include, is missing (but needed), or the #ifdef guard is >> omitted ? I'd assume 1 & 3 shouldn't be too hard to grep through. >> Note: I'm neither suggesting that you should do it, nor volunteering >> :-) > > About #3: we avoid config.h in NetBSD's xsrc, so we'll report any we > find (see the xmag ones today for example). > We have a fool proof method of checking that one. Nice ! > Thanks for not volunteering me :) Np and thanks for considering my suggestions. Emil _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
