Hi Krzysztof,
----- Original Message -----
> From: Krzysztof Sobiecki <[email protected]>
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=87806
>
> Signed-off-by: Krzysztof A. Sobiecki <[email protected]>
> ---
So if I understand correctly, this patch adds the client interface but does not
actually implement any of the VidModeExtension real logic, it's just to please
the clients that would refuse to run without VidModeExtension? If so maybe it
should be explicitly stated in the commit message.
More worryingly, I tried xvidtune with that patch applied and that led to a
crash in Xwayland - I'll investigate further to see if this is something in my
tree or with the patch as I suspect.
> diff --git a/hw/xwayland/xf86VidMode.c b/hw/xwayland/xf86VidMode.c
> new file mode 100644
> index 0000000..4e9ca71
> --- /dev/null
> +++ b/hw/xwayland/xf86VidMode.c
> @@ -0,0 +1,358 @@
[...]
> +#ifdef XF86VIDMODE
> +
> +static Bool
> +VidModeClose(ScreenPtr pScreen)
> +{
> + return TRUE;
> +
> +}
gcc complains hat this is not used and I tend to agree, I don't see this
function being used anywhere
> +
> +static Bool
> +VidModeAvailable(int scrnIndex)
> +{
> + return TRUE;
> +}
Ditto here, I don't see this function being used anywhere, I think these should
be removed if not used (it builds fine without apparently).
Cheers,
Olivier
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
