On Tue, 2015-10-20 at 11:02 -0700, Jeremy Huddleston Sequoia wrote: > Note that I'm not 100% confident that this is correct. It looks > right to me, but I'm certainly no expert here. That file is chuck > full of cpp-goop that makes my head spin. > > The reason we hadn't seen this until recently is that we were using > -DFAKEIT for builds on darwin because we didn't care about that code > anyways (we just use fake, null, nested drivers). That was removed > in 80446086b9cfcc5e23a400d7fa38ec773fae68fc, and we are just now > jumping to 1.17.x for the next XQuartz release. Note that tinderbox > would've caught this if it were still alive =(
I think this is probably fine - it builds fine on Linux at least - but I think we can do better. When I unifdef'd GCCUSESGAS I could probably have done so as if it were always defined instead of undefined, since that's what the monolith effectively did. Had I done so then the wacky %B0-syntax-using code would have been deleted instead. I'll send a patch to move both i386 and ia64 to the amd64 code, which will have the pleasant side effect of being a net deletion. Anything to make compiler.h smaller has to be good... - ajax _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
