Peter Hutterer <[email protected]> writes: > we should really move that lot into a helper function...
Well, now that growing the queue happens while queuing events, we might
just remove it entirely. Unless we run out of memory, it'll never happen
now.
>> -
>> - return;
>> + oldtail = miEventQueue.tail;
>
> this assignment has no effect
I think you're mistaken. mieqGrowQueue reallocates the queue and moves
all of the events to the first elements in the new queue. At the end of
that function, it does:
/* And update our record */
eventQueue->tail = n_enqueued;
eventQueue->head = 0;
If we don't update 'oldtail', then we will wreck the event queue.
> Reviewed-by: Peter Hutterer <[email protected]> otherwise
Thanks, I'll pend putting this in the patch until we've settled on the
oldtail stuff; that seems important.
--
-keith
signature.asc
Description: PGP signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
