On 24.12.2015 10:42, Keith Packard wrote: > Michel Dänzer <[email protected]> writes: > >> From: Michel Dänzer <[email protected]> >> >> This will switch from HW cursor to SW cursor in the following cases: >> * A transform is present on a CRTC >> * This screen is a GPU screen acting as an output slave for another >> screen > > Could this be done in xf86Crtc.c instead? That would catch all of the > drivers in one place.
Yes, in fact, your previous review e-mails already got me thinking, and I'd come to the conclusion that the new driver hook is neither necessary nor a particularly good solution for the problems this series sets out to solve. E.g. it would complicate things if somebody wants to allow using HW cursors for some special cases of transforms in the future. It's cleaner if this is handled inside xf86Cursors.c, and the driver just receives the final cursor image (and coordinates). New series addressing this on the way. Thanks for your review of this series. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
