Hi Pascal, For the future please include the project/repo in the subject prefix -> [PATCH xf86-video-fbdev]
On 22 January 2016 at 00:26, Pascal Terjan <[email protected]> wrote: > Else it is read before initialization if XSERVER_LIBPCIACCESS is not defined > or location.type is not BUS_PCI. > > Noticed when I got a segfault where it was 0x1 while doing some tests on arm. > > Signed-off-by: Pascal Terjan <[email protected]> Not sure how useful fbdev on arm/platform devices is ... regardless Reviewed-by: Emil Velikov <[email protected]> > --- > src/fbdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/fbdev.c b/src/fbdev.c > index dcfed28..2c658fe 100644 > --- a/src/fbdev.c > +++ b/src/fbdev.c > @@ -427,7 +427,7 @@ FBDevPreInit(ScrnInfoPtr pScrn, int flags) > int default_depth, fbbpp; > const char *s; > int type; > - void *pci_dev; > + void *pci_dev = NULL; > Looks like this should have been part of ae0aeffae66 "Pass the pci device (if any) through to fbdevhw in probe and preinit" Adam, can you please commit this if it looks ok ? Thanks Emil _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
