Hi Michael, On 03/23/2016 06:14 PM, Michael Thayer wrote:
Looks good at first quick glance (I am away from the computer a bit over the Easter weeks, I will take another look when I am back). One thing I can say immediately though: when I submitted similar patches a while back, Keith had the idea of keeping the old hooks untouched and adding in the additional "checked" variants so that existing driver code does not have to be changed to keep working. The other thing is that this might need a bump of ABI_XINPUT_VERSION.
Thanks for the comments. It has actually been suggested to me to define a new _checked() variant of the set_cursor hooks, but since this patch changes all the call sites I refrained from doing it. However your message sounds like there are users of these hooks outside the xserver package, is this correct? (sorry, I'm a complete X n00b).
If so I will resend as you suggested, and also bump ABI_XINPUT_VERSION. Thanks! Alex. ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
