On Fri, Apr 29, 2016 at 10:24:17AM +0200, Mark Kettenis wrote: > > Date: Fri, 29 Apr 2016 09:34:08 +0200 > > From: Julien Cristau <[email protected]> > > > > On Thu, Apr 28, 2016 at 16:10:01 +0200, Mark Kettenis wrote: > > > > > > From: Stefan Dirsch <[email protected]> > > > > Date: Thu, 28 Apr 2016 14:35:00 +0200 > > > > > > > > Builtin modesetting driver didn't work on 32bit on cirrus KMS. See > > > > https://bugzilla.suse.com/show_bug.cgi?id=917385 for more details. > > > > > > I think selectively compiling with -D_FILE_OFFSET_BITS=64 is a > > > seriously bad idea. Either evrything should be compiled with that > > > switch, or nothing. And adding a #define like that after including > > > some other header files is even worse. > > > > > I think the right fix for the referenced bug was > > https://cgit.freedesktop.org/xorg/xserver/commit/?id=4962c8c08842d9d3ca66d254b1ce4cacc4fb3756 > > so this patch should not be necessary anyway. > > Yup. That should do it. I agree that this patch shouldn't be > necessary anymore.
I agree. Sorry for the noise. It wasn't too obvious to me, that the issue was already addressed upstream. Thanks, Stefan Public Key available ------------------------------------------------------ Stefan Dirsch (Res. & Dev.) SUSE LINUX GmbH Tel: 0911-740 53 0 Maxfeldstraße 5 FAX: 0911-740 53 479 D-90409 Nürnberg http://www.suse.de Germany --------------------------------------------------------------- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --------------------------------------------------------------- _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
