On 12 May 2016 at 18:47, Keith Packard <[email protected]> wrote: > Emil Velikov <[email protected]> writes: > >> This will enable it on more platforms than just Linux. > > Right, the goal is to use it where available. > The commit summary does not mention anything, just the revision log suggests "linux only". Worth adding a couple of words to clarify things ?
>> You can use AX_PTHREAD here, instead of open-coding it. > > Thanks. I've updated the series to do this; it's on my input-thread > branch in git://people.freedesktop.org/~keithp/xserver > >> Then again I'm wondering if linking with pthread, won't lead to some >> noticeable perf degradation, as a fair few POSIX functions will now >> pthread_mutex_lock/unlock as opposed using the Glibc stub. > > The big concern I had years ago when we looked at this was malloc, but > glibc uses arenas to avoid contention, and uncontended mutexes are > pretty cheap these days. > > stdio is a disaster, but we don't use that in any critical paths. > > I haven't been able to measure any performance impact from this series, > but I've only tested on Linux. > Good enough for me. Thanks Keith. -Emil _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
