Hi Egbert you defintely have my
Reviewed-by: Stefan Dirsch <[email protected]> But could you still fix the typo in the changelog (relace -> replace) and mention the bugreport https://bugzilla.opensuse.org/show_bug.cgi?id=981522 as reference? And also add that the issue has been reproduced on 32bit systems only? Thanks, Stefan On Mon, May 30, 2016 at 12:01:14AM +0200, Egbert Eich wrote: > From: Egbert Eich <[email protected]> > > We already use the AC_SYS_LARGEFILE in configure.ac. This macro will only > work properly if the correct tyles are used: relace long by off_t when > calculating file offsets. > > Signed-off-by: Egbert Eich <[email protected]> > Found-by: Herbert Kütz <herbert.kuetz_at_ofd-z.niedersachsen.de> > --- > sessreg.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sessreg.c b/sessreg.c > index bdfe8f0..3efd8d9 100644 > --- a/sessreg.c > +++ b/sessreg.c > @@ -327,7 +327,7 @@ main (int argc, char **argv) > # else > utmp = open (utmp_file, O_RDWR); > if (utmp != -1) { > - syserr ((int) lseek (utmp, (long) slot_number * sizeof > (struct utmp), 0), "lseek"); > + syserr ((int) lseek (utmp, (off_t) slot_number * sizeof > (struct utmp), 0), "lseek"); > sysnerr (write (utmp, (char *) &utmp_entry, sizeof > (utmp_entry)) > == sizeof (utmp_entry), "write utmp > entry"); > close (utmp); > @@ -362,7 +362,7 @@ main (int argc, char **argv) > if (llog != -1) { > struct lastlog ll; > > - sysnerr (lseek(llog, (long) (pwd->pw_uid*sizeof(ll)), 0) > + sysnerr (lseek(llog, (off_t) (pwd->pw_uid*sizeof(ll)), > 0) > != -1, "seeking lastlog entry"); > memset(&ll, 0, sizeof(ll)); > ll.ll_time = current_time; > @@ -628,7 +628,7 @@ findslot (char *line_name, char *host_name, int addp, int > slot) > * first, try to locate a previous entry for this display > * also record location of a free slots in case we need a new one > */ > - syserr ((int) lseek (utmp, (long) slot * sizeof (struct utmp), 0), > "lseek"); > + syserr ((int) lseek (utmp, (off_t) slot * sizeof (struct utmp), 0), > "lseek"); > > if (!host_name) > host_name = ""; > -- > 2.7.0 Public Key available ------------------------------------------------------ Stefan Dirsch (Res. & Dev.) SUSE LINUX GmbH Tel: 0911-740 53 0 Maxfeldstraße 5 FAX: 0911-740 53 479 D-90409 Nürnberg http://www.suse.de Germany --------------------------------------------------------------- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --------------------------------------------------------------- _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
