On 30.07.2016 09:54, Keith Packard wrote: > Michel Dänzer <[email protected]> writes: > >> From: Michel Dänzer <[email protected]> >> >> Fixes crash in ScreenInit -> xf86HandleColormaps -> >> xf86RandR12LoadPalette with drivers which don't assign pScrn->pScreen >> in ScreenInit. > > That's a terrible interface. This should be fixed by wrapping the driver > ScreenInit and getting pScrn->pScreen set before the 'real' driver > ScreenInit is called; that way pScrn->pScreen will *always* be valid. > > We could then eliminate the xf86ScrnToScreen API entirely at some point. > > Here's an untested patch which should fix this:
Reviewed-and-Tested-by: Michel Dänzer <[email protected]> -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
signature.asc
Description: OpenPGP digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
